Fix Double Click not Registering Snippet 62 #2291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lipse.platform.swt.git
Member
|
Just as a note for the future - please squash all your commits into single one for such small patches. Merge commits are strongly discouraged in this repo. |
Contributor
Author
|
How do I squash the commits in my fork? I can't see a way to do that |
Member
|
https://www.datacamp.com/tutorial/git-squash-commits looks like good explanation. |
Member
|
|
Contributor
Author
|
|
Member
|
Most likely this is because you try to squash commits from different chains and also include merge commits. |
Contributor
Author
|
I made a new pull request with just the one commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 344.
Running snippet 62 and double clicking used to register two up events but only one down event when there should also have been two. This was due to the use of SWT.MouseDoubleClick instead of SWT.MouseDown. I have modified it such that in the event SWT.MouseDoubleClick fails, SWT.MouseDown is tried instead. This keeps the double click as an option for the future if support is added.
I also changed the behaviour so triple clicks and higher are now treated as double clicks rather than being ignored.